[webkit-reviews] review granted: [Bug 65126] don't show builders in the flakiness dashboard that have stopped running a given test suite : [Attachment 101895] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 25 12:51:03 PDT 2011


Mihai Parparita <mihaip at chromium.org> has granted Ojan Vafai
<ojan at chromium.org>'s request for review:
Bug 65126: don't show builders in the flakiness dashboard that have stopped
running a given test suite
https://bugs.webkit.org/show_bug.cgi?id=65126

Attachment 101895: Patch
https://bugs.webkit.org/attachment.cgi?id=101895&action=review

------- Additional Comments from Mihai Parparita <mihaip at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=101895&action=review


> Tools/TestResultServer/static-dashboards/dashboard_base.js:481
> +	   var twoWeeksSeconds = 60 * 60 * 24 * 14;

Perhaps move to the constants block at the top?


More information about the webkit-reviews mailing list