[webkit-reviews] review denied: [Bug 64494] Fix leveldb crash when compacting during destruction : [Attachment 101887] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 25 12:32:17 PDT 2011


Nate Chapin <japhet at chromium.org> has denied David Grogan
<dgrogan at chromium.org>'s request for review:
Bug 64494: Fix leveldb crash when compacting during destruction
https://bugs.webkit.org/show_bug.cgi?id=64494

Attachment 101887: Patch
https://bugs.webkit.org/attachment.cgi?id=101887&action=review

------- Additional Comments from Nate Chapin <japhet at chromium.org>
Rather than depending on the ordering in the header file, we should probably
manually destroy the OwnPtr<>s in the destructor by calling .clear() on them in
the proper order.


More information about the webkit-reviews mailing list