[webkit-reviews] review denied: [Bug 65110] Web Inspector: use dedicated type for object id in the protocol. : [Attachment 101868] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has denied Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 65110: Web Inspector: use dedicated type for object id in the protocol.
https://bugs.webkit.org/show_bug.cgi?id=65110

Attachment 101868: Patch
https://bugs.webkit.org/attachment.cgi?id=101868&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=101868&action=review


> Source/WebCore/inspector/InjectedScriptSource.js:289
> +	       args = JSON.parse(args);

JSON.parse may be overriden, use safe eval.

> Source/WebCore/inspector/InjectedScriptSource.js:304
> +		       return "Call argument should either contain object id or
value property.";

Please add undefined argument handling.