[webkit-reviews] review granted: [Bug 65103] Web Inspector: refactor remote object structure to contain value for primitive values. : [Attachment 101864] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 65103: Web Inspector: refactor remote object structure to contain value for
primitive values.
https://bugs.webkit.org/show_bug.cgi?id=65103

Attachment 101864: Patch
https://bugs.webkit.org/attachment.cgi?id=101864&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=101864&action=review


> Source/WebCore/inspector/Inspector.json:226
> +		       { "name": "subtype", "type": "string", "optional": true,
"enum": ["array", "null", "node", "undefined", "regexp", "date"],
"description": "Object subtype hint. Specified for only for <code>object</code>
type values only." },

There is undefined type.

> Source/WebCore/inspector/Inspector.json:227
> +		       { "name": "className", "type": "string", "optional":
true, "description": "Object class (constructor) name. Specified for only for
<code>object</code> type values only." },

Please leave only only.

> Source/WebCore/inspector/front-end/ConsoleView.js:852
> +	       if (parameters[i] instanceof WebInspector.RemoteObject)

Please put a FIXME to extract this parameter conversion out of this method.

> Source/WebCore/inspector/front-end/RemoteObject.js:43
> +	   this._hasChildren = false;

this._value = value?