[webkit-reviews] review granted: [Bug 65090] Small cleanup of m_fontDirty tracking in CSSStyleSelector : [Attachment 101845] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Jul 24 20:13:07 PDT 2011
Darin Adler <darin at apple.com> has granted Luke Macpherson
<macpherson at chromium.org>'s request for review:
Bug 65090: Small cleanup of m_fontDirty tracking in CSSStyleSelector
https://bugs.webkit.org/show_bug.cgi?id=65090
Attachment 101845: Patch
https://bugs.webkit.org/attachment.cgi?id=101845&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=101845&action=review
Please consider doing this without the name change.
> Source/WebCore/ChangeLog:8
> + 1) Use exising setFontDescription helper where appropriate.
Typo: existing
> Source/WebCore/css/CSSStyleSelector.cpp:1997
> -void CSSStyleSelector::updateFont()
> +void CSSStyleSelector::updateFontIfDirty()
I don’t think we need the name change. It’s great to move the check into the
function, even without changing the function name to make that explicit.
More information about the webkit-reviews
mailing list