[webkit-reviews] review denied: [Bug 65084] Build without video but fullscreen API is broken : [Attachment 101833] Patch fixing missing isMediaElement() when building without video but fullscreen API

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Denis Oliver Kropp
<dok at directfb.org>'s request for review:
Bug 65084: Build without video but fullscreen API is broken
https://bugs.webkit.org/show_bug.cgi?id=65084

Attachment 101833: Patch fixing missing isMediaElement() when building without
video but fullscreen API
https://bugs.webkit.org/attachment.cgi?id=101833&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=101833&action=review


> Source/WebCore/dom/Element.h:315
> -#if ENABLE(VIDEO)
> +#if ENABLE(VIDEO) || ENABLE(FULLSCREEN_API)

This is the wrong fix. The right fix is to put the code in
EventDispatcher::determineDispatchBehavior inside this:

    #if ENABLE(FULLSCREEN_API) && ENABLE(VIDEO)