[webkit-reviews] review granted: [Bug 65066] Extract TestConfiguration from base and write a few unit tests to capture current behavior. : [Attachment 101811] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Dimitri Glazkov (Google)
<dglazkov at chromium.org>'s request for review:
Bug 65066: Extract TestConfiguration from base and write a few unit tests to
capture current behavior.
https://bugs.webkit.org/show_bug.cgi?id=65066

Attachment 101811: Patch
https://bugs.webkit.org/attachment.cgi?id=101811&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=101811&action=review


> Tools/Scripts/webkitpy/layout_tests/models/test_configuration.py:55
> +    def all_test_configurations(self):

@classmethod ?

> Tools/Scripts/webkitpy/layout_tests/models/test_configuration.py:70
> +    def all_systems(self):

@classmethod ?

> Tools/Scripts/webkitpy/layout_tests/models/test_configuration.py:79
> +    def all_build_types(self):

@classmethod ?

> Tools/Scripts/webkitpy/layout_tests/models/test_configuration.py:82
> +    def all_graphics_types(self):

@classmethod ?