[webkit-reviews] review granted: [Bug 65064] Don't use group separators in formatting input[type=number] : [Attachment 101810] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Jul 23 08:22:35 PDT 2011
Kent Tamura <tkent at chromium.org> has granted Shinya Kawanaka
<shinyak at google.com>'s request for review:
Bug 65064: Don't use group separators in formatting input[type=number]
https://bugs.webkit.org/show_bug.cgi?id=65064
Attachment 101810: Patch
https://bugs.webkit.org/attachment.cgi?id=101810&action=review
------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=101810&action=review
The patch have some issues. But I think it's ok to land this.
> LayoutTests/ChangeLog:3
> + Marked fast/speech/input-appearance-numberandspeech.html flaky on
Mac and Windows.
No. It won't be flaky on Mac and Windows.
Flaky means that the result of a test is not stable without any change related
to the test. In this case, we expect the test will fail by this change. So the
test expectation should be:
BUGWK65064 WIN MAC : fast/speech/input-appearance-numberandspeech.html = FAIL
>
LayoutTests/platform/chromium-mac/fast/speech/input-appearance-numberandspeech-
expected.txt:164
> layer at (14,48) size 81x10 scrollWidth 172
This file is not listed in LayoutTests/ChangeLog.
Also, we should not update a render tree dump without updating the
corresponding PNG in Chromium port.
More information about the webkit-reviews
mailing list