[webkit-reviews] review denied: [Bug 53767] SVG <use> element is not repositioned when moved to x=0 y=0 through script : [Attachment 101798] Patch

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has denied Rob Buis
<rwlbuis at gmail.com>'s request for review:
Bug 53767: SVG <use> element is not repositioned when moved to x=0 y=0 through
script
https://bugs.webkit.org/show_bug.cgi?id=53767

Attachment 101798: Patch
https://bugs.webkit.org/attachment.cgi?id=101798&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=101798&action=review


>> Source/WebCore/rendering/svg/SVGShadowTreeElements.cpp:53
>> +	   
static_cast<RenderSVGTransformableContainer*>(renderer())->setNeedsTransformUpd
ate();
> 
> Si it is not only 0,0 affected but every other position as well? Because
according your patch I don't see a reason why just 0,0 should be affected.

The more interessting question is why would you need a "transform update" if
transform did not change?

Note that RenderSVGShadowTreeRootContainer inherits from
RenderSVGTransformableContainer, and
bool RenderSVGTransformableContainer::calculateLocalTransform()

contains special code to apply the container offset to the local transform.
This should work even _without_ touching setNeedsTransformUpdate.
If it doesn't there's another bug that you're hiding by this workaround.

r- for this reason.