[webkit-reviews] review granted: [Bug 58374] WebKit2: Clients have to know not to call TranslateMessage() on key messages destined for WebKit2 web views : [Attachment 101792] Take 2: Remove old key handling test and add a new one, and update MiniBrowser to always call TranslateMessage() again

[bugzilla-daemon at webkit.org]

Adam Roben (:aroben) <aroben at apple.com> has granted Jeff Miller
<jeffm at apple.com>'s request for review:
Bug 58374: WebKit2: Clients have to know not to call TranslateMessage() on key
messages destined for WebKit2 web views
https://bugs.webkit.org/show_bug.cgi?id=58374

Attachment 101792: Take 2: Remove old key handling test and add a new one, and
update MiniBrowser to always call TranslateMessage() again
https://bugs.webkit.org/attachment.cgi?id=101792&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=101792&action=review


> Tools/TestWebKitAPI/Tests/WebKit2/win/key-event-handling.html:38
> +    function loaded()
> +    {
> +	   setFocusToField1();
> +    }
> +
> +    addEventListener("load", loaded);

You might be able to use the autofocus attribute instead.

> Tools/TestWebKitAPI/win/PlatformUtilitiesWin.cpp:59
> +void runUntil(double timeoutInMS)

Usually we use double to represent time in seconds. (This is inherited from
NS/CFTimeInterval/AbsoluteTime.) I think it would be good to do that here, too.


> Tools/TestWebKitAPI/win/PlatformUtilitiesWin.cpp:68
> +	   DWORD result = ::MsgWaitForMultipleObjectsEx(0, 0, endTime-now,
QS_ALLINPUT, MWMO_INPUTAVAILABLE);

Missing spaces around '-'.