[webkit-reviews] review denied: [Bug 63339] JSON errors should be informative : [Attachment 101797] proposed patch

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has denied Juan C. Montemayor
<jmont at apple.com>'s request for review:
Bug 63339: JSON errors should be informative
https://bugs.webkit.org/show_bug.cgi?id=63339

Attachment 101797: proposed patch
https://bugs.webkit.org/attachment.cgi?id=101797&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=101797&action=review


Seems like one more round is necessary

> Source/JavaScriptCore/runtime/LiteralParser.cpp:499
> +		       m_parseErrorMessage = "Expected right bracket at end of
array expression";

expected ]

> Source/JavaScriptCore/runtime/LiteralParser.cpp:519
> +			   m_parseErrorMessage = "Expected colon before value
in object definition";

Expected ':' before value in object property definition

> Source/JavaScriptCore/runtime/LiteralParser.cpp:529
> +		       m_parseErrorMessage = "Expected right brace at the end
of object definition";

'}'

> Source/JavaScriptCore/runtime/LiteralParser.cpp:548
> +		       m_parseErrorMessage = "Expected colon before value in
object definition";

':'

> Source/JavaScriptCore/runtime/LiteralParser.cpp:564
> +		       m_parseErrorMessage = "Expected right brace at end of
object expression";

'}'

> Source/JavaScriptCore/runtime/LiteralParser.cpp:668
> +			   m_parseErrorMessage = String::format("Could not
parse \"%s\"",
UString(m_lexer.currentToken().stringToken).ascii().data()).impl();

Unexpected identifier "%s"