[webkit-reviews] review granted: [Bug 65030] Avoiding painting backgrounds if they are fully obscures by an object's foreground : [Attachment 101774] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 22 17:02:42 PDT 2011


mitz at webkit.org has granted Simon Fraser (smfr) <simon.fraser at apple.com>'s
request for review:
Bug 65030: Avoiding painting backgrounds if they are fully obscures by an
object's foreground
https://bugs.webkit.org/show_bug.cgi?id=65030

Attachment 101774: Patch
https://bugs.webkit.org/attachment.cgi?id=101774&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=101774&action=review


> Source/WebCore/ChangeLog:8
> +	   Some pages used animated loading GIFs as the background of <img>,

Confused by the use of “used” in the past tense.

> Source/WebCore/rendering/RenderImage.cpp:411
> +    if (!image->isBitmapImage())

I think you need to null-check image.


More information about the webkit-reviews mailing list