[webkit-reviews] review denied: [Bug 64981] export JSContextGetBacktrace as SPI in JSContextRefPrivate.h : [Attachment 101780] same backtrace patch with tabs removed from ChangeLog

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has denied  review:
Bug 64981: export JSContextGetBacktrace as SPI in JSContextRefPrivate.h
https://bugs.webkit.org/show_bug.cgi?id=64981

Attachment 101780: same backtrace patch with tabs removed from ChangeLog
https://bugs.webkit.org/attachment.cgi?id=101780&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=101780&action=review


> Source/JavaScriptCore/API/JSContextRef.cpp:211
> +	   char levelStr[6];
> +	   sprintf(levelStr, "#%d ", count);

should be snprintf if anything i guess, but...

> Source/JavaScriptCore/API/JSContextRef.cpp:226
> +	   builder.append(levelStr);

Can you not just use UString::number() here instead?