[webkit-reviews] review granted: [Bug 64852] [Chromium] Turn on new WebSocket protocol in worker shadow page : [Attachment 101723] Patch v2 (add FIXME comment)

[bugzilla-daemon at webkit.org]

Dmitry Titov <dimich at chromium.org> has granted Yuta Kitamura
<yutak at chromium.org>'s request for review:
Bug 64852: [Chromium] Turn on new WebSocket protocol in worker shadow page
https://bugs.webkit.org/show_bug.cgi?id=64852

Attachment 101723: Patch v2 (add FIXME comment)
https://bugs.webkit.org/attachment.cgi?id=101723&action=review

------- Additional Comments from Dmitry Titov <dimich at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=101723&action=review


r=me with a note.

> Source/WebKit/chromium/src/WebWorkerBase.cpp:242
> +    // FIXME: Should copy the value of Settings::hixie76ProtocolEnabled() of
a view in the main thread.

This code is running in the main WebKit thread, but it runs in a sandboxed
Worker process. Settings information should be passed to the Worker process
from Browser process when the worker is created (similar to
RenderThread::OnCreateNewView).  Could you please change the comment to reflect
this?