[webkit-reviews] review denied: [Bug 65027] Inserting text into scrolled out text controls should bring them into the center of the view, not on an edge : [Attachment 101727] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Mikhail Naganov
<mnaganov at chromium.org>'s request for review:
Bug 65027: Inserting text into scrolled out text controls should bring them
into the center of the view, not on an edge
https://bugs.webkit.org/show_bug.cgi?id=65027

Attachment 101727: Patch
https://bugs.webkit.org/attachment.cgi?id=101727&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
What happens when scrolling horizontally is certainly an interesting additional
question, and it's great that looking at svn blame made us think of it. Looking
at native Cocoa text controls (such as search field in Safari) suggests that
scrolling to center the insertion point will be correct.

> Should I fire a bug about this?

Thank you for offering to file a bug. It is known that iOS doesn't support
contenteditable. Anyway, the correct behavior on that test shouldn't differ
from <input type=text> on any platform, so you could try that.

Of course, the final patch will need to include tests for both horizontal and
vertical scrolling, in both forms and contenteditable. I'm going to mark r- due
to lack of tests now, given that several people who would care about such
change are already CC'ed.