[webkit-reviews] review granted: [Bug 64985] hook in the rest of the bots to the dashboard now they run NRWT : [Attachment 101749] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 22 11:58:44 PDT 2011


Adam Barth <abarth at webkit.org> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 64985: hook in the rest of the bots to the dashboard now they run NRWT
https://bugs.webkit.org/show_bug.cgi?id=64985

Attachment 101749: Patch
https://bugs.webkit.org/attachment.cgi?id=101749&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
I'm marking this patch r+ because I feel like you're the owner of this code and
you should set its direction.  This isn't the approach I would take because it
feels like adding "non-chromium" as a special case rather that moving all the
"chromium stuff" into chromium-specific names.	From a project-wide point of
view, Chromium is a special case of WebKit, which is why we have things like
chromium-mac and we should rename LayoutTests/platform/mac to
LayoutTests/platform/apple-mac.  That's a somewhat larger project than what
you're trying to accomplish here, and I can understand the value of getting
something working as a base to start iterating from.


More information about the webkit-reviews mailing list