[webkit-reviews] review denied: [Bug 64580] Add support for download='filename' in anchors : [Attachment 101736] updated

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 22 09:27:33 PDT 2011


Adam Barth <abarth at webkit.org> has denied sadrul at chromium.org's request for
review:
Bug 64580: Add support for download='filename' in anchors
https://bugs.webkit.org/show_bug.cgi?id=64580

Attachment 101736: updated
https://bugs.webkit.org/attachment.cgi?id=101736&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=101736&action=review


I like the new approach of not change ResourceRequestBase.  Two comments below.


> Source/WebCore/html/HTMLAnchorElement.cpp:512
> +	       if (!referrer.isEmpty())
> +		   request.setHTTPReferrer(referrer);

Don't we need to call shouldHideReferrer?

> Source/WebCore/html/HTMLAnchorElement.idl:29
> +	   attribute [Reflect] DOMString download;

Looks like we still have the problem of this feature being half-implemented on
non-Chromium ports.  We either need to fully implementing it or have it be
invisible.  I'm not sure we can fully implement it without changing the
embedders on those platforms, so we'll probably need to disable it.


More information about the webkit-reviews mailing list