[webkit-reviews] review granted: [Bug 64921] Layout tests for validating the new WebVTT Parser : [Attachment 101610] moving tests to media/track

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Anna Cavender
<annacc at chromium.org>'s request for review:
Bug 64921: Layout tests for validating the new WebVTT Parser
https://bugs.webkit.org/show_bug.cgi?id=64921

Attachment 101610: moving tests to media/track
https://bugs.webkit.org/attachment.cgi?id=101610&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=101610&action=review


> LayoutTests/media/track/track-webvtt-tc003-newlines.html:19
> +		   testExpected("video.textTracks["+i+"].cues.length", "1");
> +		   
> +		   testExpected("video.textTracks["+i+"].cues[0].id","1");
> +		  
testExpected("video.textTracks["+i+"].cues[0].startTime","0.0");
> +		  
testExpected("video.textTracks["+i+"].cues[0].endTime","30.5");
> +		  
testExpected("video.textTracks["+i+"].cues[0].getCueAsSource()", "Bear is
Coming!!!!!");

Nit: I think the WebKit style is to have a space on both sides of the '+': 
video.textTracks[" + i + "] (here and elsewhere).

> LayoutTests/media/track/track-webvtt-tc003-newlines.html:29
> +		   numberTests++;
> +		   allTestsEnded();
> +	       }
> +	       
> +	       function allTestsEnded()
> +	       {
> +		   if (numberTests >= 2)
> +		       endTest();
> +	       }

Nit: I think it would be slightly clearer to increment the global in
allTestsEnded (here and elsewhere).