[webkit-reviews] review granted: [Bug 65007] [Qt] Add option to turn on disk caching in QtTestBrowser : [Attachment 101694] Patch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam.rosenthal at nokia.com> has granted Keith Kyzivat
<keith.kyzivat at nokia.com>'s request for review:
Bug 65007: [Qt] Add option to turn on disk caching in QtTestBrowser
https://bugs.webkit.org/show_bug.cgi?id=65007

Attachment 101694: Patch
https://bugs.webkit.org/attachment.cgi?id=101694&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=101694&action=review


> Tools/QtTestBrowser/launcherwindow.cpp:808
> +	   qDebug() << "Using disk cache location: " << cacheLocation;
> +	   cache->setCacheDirectory(cacheLocation);
> +    }
> +    page()->networkAccessManager()->setCache(cache);
> +    qDebug() << "disk cache" << (enable ? "enabled" : "disabled");

Please remove qDebug() before committing. Those tend to clutter after a while.