[webkit-reviews] review denied: [Bug 11274] Implement getIntersectionList(), getEnclosureList(), checkIntersection() and checkEnclosure() in SVGSVGElement : [Attachment 101502] Patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has denied Rob Buis <rwlbuis at gmail.com>'s
request for review:
Bug 11274: Implement getIntersectionList(), getEnclosureList(),
checkIntersection() and checkEnclosure() in SVGSVGElement
https://bugs.webkit.org/show_bug.cgi?id=11274

Attachment 101502: Patch
https://bugs.webkit.org/attachment.cgi?id=101502&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=101502&action=review


> Source/WebCore/rendering/svg/RenderSVGRoot.cpp:516
> +    if (!renderer || renderer->style()->pointerEvents() == PE_NONE)
> +	   return false;
> +    if (!isGraphicsElement(renderer))
> +	   return false;
> +    AffineTransform ctm;
> +    getElementCTM(static_cast<SVGElement*>(renderer->node()), ctm);
> +    return intersectsAllowingEmpty(rect,
ctm.mapRect(renderer->repaintRectInLocalCoordinates()));

Niko is right. And because you return earlier for !isGraphicsElement You can
savely cast to a SVG specific renderer.