[webkit-reviews] review denied: [Bug 65006] Draw rectangular box shadow for elements with border-radius if no corners are visible : [Attachment 101692] proposed patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Ian Henderson
<ianh at apple.com>'s request for review:
Bug 65006: Draw rectangular box shadow for elements with border-radius if no
corners are visible
https://bugs.webkit.org/show_bug.cgi?id=65006

Attachment 101692: proposed patch
https://bugs.webkit.org/attachment.cgi?id=101692&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=101692&action=review


> Source/WebCore/rendering/RenderBoxModelObject.cpp:2174
> +    unroundClippedCorners(border, info.rect);

I don't think this is right. The effect of the corner radius can propagate
further for the shadow than the corner radius itself; you have to add the blur
radius (or maybe twice the blur radius).