[webkit-reviews] review granted: [Bug 65002] Get authentication to work with USE(CFNETWORK) on Mac : [Attachment 101683] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 21 21:02:43 PDT 2011


David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Pratik Solanki
<psolanki at apple.com>'s request for review:
Bug 65002: Get authentication to work with USE(CFNETWORK) on Mac
https://bugs.webkit.org/show_bug.cgi?id=65002

Attachment 101683: Patch
https://bugs.webkit.org/attachment.cgi?id=101683&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=101683&action=review


r=me

> Source/WebCore/platform/network/mac/AuthenticationMac.mm:62
> +    CFURLAuthChallengeRef m_cfChallenge;

Should this be retained using a RetainPtr<CFURLAuthChallengeRef>?


More information about the webkit-reviews mailing list