[webkit-reviews] review requested: [Bug 64989] [Qt] Fix tst_QDeclarativeWebView::historyNav() autotests : [Attachment 101658] Quick fix for the test failures. Force a stop action, so I can assure the QWebPage actions are updated.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jul 21 16:07:45 PDT 2011
Rafael Brandao <rafael.lobo at openbossa.org> has asked for review:
Bug 64989: [Qt] Fix tst_QDeclarativeWebView::historyNav() autotests
https://bugs.webkit.org/show_bug.cgi?id=64989
Attachment 101658: Quick fix for the test failures. Force a stop action, so I
can assure the QWebPage actions are updated.
https://bugs.webkit.org/attachment.cgi?id=101658&action=review
------- Additional Comments from Rafael Brandao <rafael.lobo at openbossa.org>
Even though it was passing there (XPASS) the output is still wrong, but I'll
fix it soon.
If anyone else wants to look deeper on this, feel welcome. The problem lies
around the lack of updates on QWebPage actions, so at some point we check if it
is enabled and it's not updated yet. I've realized when I do the stop action,
it calls updateNavigationActions from QWebPagePrivate and it was enough to fix
it. Maybe a better fix is to update the actions as soon as the loadFinished is
triggered.
More information about the webkit-reviews
mailing list