[webkit-reviews] review granted: [Bug 64973] Add [Optional=CallWithDefaultValue] flag and use it in initXXXEvent declarations : [Attachment 101639] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Mark Pilgrim
<pilgrim at chromium.org>'s request for review:
Bug 64973: Add [Optional=CallWithDefaultValue] flag and use it in initXXXEvent
declarations
https://bugs.webkit.org/show_bug.cgi?id=64973

Attachment 101639: Patch
https://bugs.webkit.org/attachment.cgi?id=101639&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=101639&action=review


> Source/WebCore/dom/MessageEvent.idl:40
> -	   [Custom] void initMessageEvent(in DOMString typeArg, in boolean
canBubbleArg, in boolean cancelableArg, in SerializedScriptValue dataArg, in
DOMString originArg, in DOMString lastEventIdArg, in DOMWindow sourceArg, in
Array messagePorts);
> +	   [Custom] void initMessageEvent(in [Optional=CallWithDefaultValue]
DOMString typeArg, in [Optional=CallWithDefaultValue] boolean canBubbleArg, in
[Optional=CallWithDefaultValue] boolean cancelableArg, in
[Optional=CallWithDefaultValue] SerializedScriptValue dataArg, in
[Optional=CallWithDefaultValue] DOMString originArg, in
[Optional=CallWithDefaultValue] DOMString lastEventIdArg, in
[Optional=CallWithDefaultValue] DOMWindow sourceArg, in
[Optional=CallWithDefaultValue] Array messagePorts);

I'd reformat this onto multiple lines.

> Source/WebCore/dom/MessageEvent.idl:45
> -	   void initMessageEvent(in DOMString typeArg, in boolean canBubbleArg,
in boolean cancelableArg, in SerializedScriptValue dataArg, in DOMString
originArg, in DOMString lastEventIdArg, in DOMWindow sourceArg, in MessagePort
messagePort);
> +	   void initMessageEvent(in [Optional=CallWithDefaultValue] DOMString
typeArg, in [Optional=CallWithDefaultValue] boolean canBubbleArg, in
[Optional=CallWithDefaultValue] boolean cancelableArg, in
[Optional=CallWithDefaultValue] SerializedScriptValue dataArg, in
[Optional=CallWithDefaultValue] DOMString originArg, in
[Optional=CallWithDefaultValue] DOMString lastEventIdArg, in
[Optional=CallWithDefaultValue] DOMWindow sourceArg, in
[Optional=CallWithDefaultValue] MessagePort messagePort);

This too.