[webkit-reviews] review granted: [Bug 64535] Add fast path for ImageBuffer::draw : [Attachment 101641] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 21 13:37:27 PDT 2011


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Matthew Delaney
<mdelaney at apple.com>'s request for review:
Bug 64535: Add fast path for ImageBuffer::draw
https://bugs.webkit.org/show_bug.cgi?id=64535

Attachment 101641: Patch
https://bugs.webkit.org/attachment.cgi?id=101641&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=101641&action=review


> Source/WebCore/platform/graphics/ImageBuffer.h:91
> +	   PassRefPtr<Image> copyImage(BackingStoreCopy copyPreference =
CopyBackingStore) const;

I don't like copyPreference; it sounds related to preferences. copyBehavior
would be better. You don't even need to include a parameter name here.


More information about the webkit-reviews mailing list