[webkit-reviews] review granted: [Bug 62599] Errors encountered within SVG documents should be reported to the console : [Attachment 101607] 0003 - Make use of SVGLength::construct (and update the tests)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 21 13:12:36 PDT 2011


Nikolas Zimmermann <zimmermann at kde.org> has granted Tim Horton
<timothy_horton at apple.com>'s request for review:
Bug 62599: Errors encountered within SVG documents should be reported to the
console
https://bugs.webkit.org/show_bug.cgi?id=62599

Attachment 101607: 0003 - Make use of SVGLength::construct (and update the
tests)
https://bugs.webkit.org/attachment.cgi?id=101607&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=101607&action=review


Looks great to me, r=me! Please take special care of Chromium, the bot is red.

> Source/WebCore/ChangeLog:9
> +	   Make use of SVGLength::construct when parsing Length attributes

Another sentence should be added, what's now changed, you've only said what you
changed.
Something regarding unify console output, etc..


More information about the webkit-reviews mailing list