[webkit-reviews] review requested: [Bug 64972] Clean up generated HTMLEntityTable.cpp output : [Attachment 101635] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jul 21 12:58:43 PDT 2011
David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked for review:
Bug 64972: Clean up generated HTMLEntityTable.cpp output
https://bugs.webkit.org/show_bug.cgi?id=64972
Attachment 101635: Patch
https://bugs.webkit.org/attachment.cgi?id=101635&action=review
------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Reviewed by NOBODY (OOPS!).
* html/parser/create-html-entity-table:
- Fix duplicate "EntityName" suffix on local variables (changes
fooSemicolonEntityNameEntityName to fooSemicolonEntityName)
for all 2138 symbols.
- Add newlines to make source file human-readable (as originally
intended).
- Add static (const) keywords to local variables that are never
referenced externally.
---
2 files changed, 25 insertions(+), 8 deletions(-)
More information about the webkit-reviews
mailing list