[webkit-reviews] review denied: [Bug 64958] Use software rendering for small canvas : [Attachment 101608] proposed patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied Alok Priyadarshi
<alokp at chromium.org>'s request for review:
Bug 64958: Use software rendering for small canvas
https://bugs.webkit.org/show_bug.cgi?id=64958

Attachment 101608: proposed patch
https://bugs.webkit.org/attachment.cgi?id=101608&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
I think you want to do the size check in reset() as well.  This does complicate
the state transitions a bit, since right now we depend on initial m_context3D
creation to succeed in order to stay in the accelerated path through reset()
calls.	With this patch if a canvas is created with width*height < 128^2 but
then resized to be larger, it won't enter the accelerated path.