[webkit-reviews] review granted: [Bug 64904] REGRESSION(r88757): input[type=range] renders incorrectly in RTL context : [Attachment 101562] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Kent Tamura <tkent at chromium.org>'s
request for review:
Bug 64904: REGRESSION(r88757): input[type=range] renders incorrectly in RTL
context
https://bugs.webkit.org/show_bug.cgi?id=64904

Attachment 101562: Patch
https://bugs.webkit.org/attachment.cgi?id=101562&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=101562&action=review


ok, looks sane to me.

>>> Source/WebCore/html/shadow/SliderThumbElement.cpp:243
>>> +	 if (isVertical || !renderBox()->style()->isLeftToRightDirection())
>> 
>> Would this work if isVertical was true and isLeftToRightDirection() was
false?
> 
> It works.
> If isVertical is true, isLeftToRightDirection() doesn't matter. We have no
LTR/RTL differences in vertical sliders.

Should we at least add a test case for it?