[webkit-reviews] review denied: [Bug 64877] [Qt] Adopt existing GraphicsContext3D members (part 1) : [Attachment 101483] adopt GraphicsContext3D members
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jul 21 01:48:32 PDT 2011
Noam Rosenthal <noam.rosenthal at nokia.com> has denied Andrew Wason
<rectalogic at rectalogic.com>'s request for review:
Bug 64877: [Qt] Adopt existing GraphicsContext3D members (part 1)
https://bugs.webkit.org/show_bug.cgi?id=64877
Attachment 101483: adopt GraphicsContext3D members
https://bugs.webkit.org/attachment.cgi?id=101483&action=review
------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=101483&action=review
The code changes are good. Please resubmit with a more informative ChangeLog.
> Source/WebCore/ChangeLog:8
> + Existing webgl layout tests should test this.
WebGL, not webgl.
> Source/WebCore/ChangeLog:11
> + where they will be needed when we adopt GraphicsContext3DOpenGL.cpp
Missing a period, this upsets some people :)
More information about the webkit-reviews
mailing list