[webkit-reviews] review requested: [Bug 60910] might need to bundle the functions related to visual word break as a class (VisualWordBreaker) : [Attachment 101541] Revised fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 20 18:33:13 PDT 2011


Van Lam <vanlam at google.com> has asked  for review:
Bug 60910: might need to bundle the functions related to visual word break as a
class (VisualWordBreaker)
https://bugs.webkit.org/show_bug.cgi?id=60910

Attachment 101541: Revised fix
https://bugs.webkit.org/attachment.cgi?id=101541&action=review

------- Additional Comments from Van Lam <vanlam at google.com>
Made requested changes; now:

1) leftWordPosition and rightWordPosition are called through non-member wrapper
functions of the same names
2) the class definition is in visible_units.cpp; the header file's dependency
on VisiblePosition is removed


More information about the webkit-reviews mailing list