[webkit-reviews] review granted: [Bug 64895] Wrong URL loaded into child frame after back/forward navigation : [Attachment 101509] patch

[bugzilla-daemon at webkit.org]

Mihai Parparita <mihaip at chromium.org> has granted Nate Chapin
<japhet at chromium.org>'s request for review:
Bug 64895: Wrong URL loaded into child frame after back/forward navigation
https://bugs.webkit.org/show_bug.cgi?id=64895

Attachment 101509: patch
https://bugs.webkit.org/attachment.cgi?id=101509&action=review

------- Additional Comments from Mihai Parparita <mihaip at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=101509&action=review


Is the current behavior (that the URL is restored for iframes for back-forward
navigations) tested anywhere?

> LayoutTests/fast/loader/child-frame-add-after-back-forward.html:9
> +   
layoutTestController.overridePreference('WebKitUsesPageCachePreferenceKey', 0);


You may want to add an unload handler too, so that the page cache is disabled
when running the test in Safari too.