[webkit-reviews] review granted: [Bug 64899] show a list of average test times in the treemap : [Attachment 101523] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jul 20 16:09:31 PDT 2011
Adam Roben (:aroben) <aroben at apple.com> has granted Ojan Vafai
<ojan at chromium.org>'s request for review:
Bug 64899: show a list of average test times in the treemap
https://bugs.webkit.org/show_bug.cgi?id=64899
Attachment 101523: Patch
https://bugs.webkit.org/attachment.cgi?id=101523&action=review
------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=101523&action=review
> Tools/TestResultServer/static-dashboards/treemap.html:206
> + if (avgA > avgB)
> + return -1;
> + else if (avgA == avgB)
> + return 0;
> + else
> + return 1;
It's simpler to say:
return avgB - avgA;
More information about the webkit-reviews
mailing list