[webkit-reviews] review denied: [Bug 64897] Minimum Row Height For PopupListBoxes should platform-dependent : [Attachment 101521] Fixed a small style issue

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied Fady Samuel
<fsamuel at chromium.org>'s request for review:
Bug 64897: Minimum Row Height For PopupListBoxes should platform-dependent
https://bugs.webkit.org/show_bug.cgi?id=64897

Attachment 101521: Fixed a small style issue
https://bugs.webkit.org/attachment.cgi?id=101521&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=101521&action=review


> Source/WebCore/platform/chromium/PlatformBridge.h:401
> +    static int getPopupListBoxMinimumRowHeight();

we don't prefix getters with "get" in WebKit

> Source/WebCore/platform/chromium/PopupMenuChromium.cpp:1179
> +    int minimumHeight =
RenderTheme::defaultTheme()->popupListBoxMinimumRowHeight();
> +

why don't you just ask PlatformBridge for the minimum row height here?

> Source/WebCore/rendering/RenderTheme.h:170
> +    virtual int popupListBoxMinimumRowHeight() const { return 0; }

this doesn't seem necessary