[webkit-reviews] review requested: [Bug 60910] might need to bundle the functions related to visual word break as a class (VisualWordBreaker) : [Attachment 101518] Revised fix (now without introducing the class hierarchy)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 20 15:16:47 PDT 2011


Van Lam <vanlam at google.com> has asked  for review:
Bug 60910: might need to bundle the functions related to visual word break as a
class (VisualWordBreaker)
https://bugs.webkit.org/show_bug.cgi?id=60910

Attachment 101518: Revised fix (now without introducing the class hierarchy)
https://bugs.webkit.org/attachment.cgi?id=101518&action=review

------- Additional Comments from Van Lam <vanlam at google.com>
The patch is still big, but almost every diff in visible_units.cpp can be
classified as either:
1) an access to a data member (which was previously passed into the function as
an argument)
2) setting a data member for the callee to access
3) a function call in which fewer arguments are passed (because now
commonly-passed arguments are saved as data members)
4) labeling previously static functions as member functions


More information about the webkit-reviews mailing list