[webkit-reviews] review granted: [Bug 64097] Web Inspector: Add support for disabling cache in web inspector. : [Attachment 101319] Patch with comments addressed (rebaselined)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 20 14:17:11 PDT 2011


Pavel Feldman <pfeldman at chromium.org> has granted Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 64097: Web Inspector: Add support for disabling cache in web inspector.
https://bugs.webkit.org/show_bug.cgi?id=64097

Attachment 101319: Patch with comments addressed (rebaselined)
https://bugs.webkit.org/attachment.cgi?id=101319&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=101319&action=review


> Source/WebCore/inspector/InspectorResourceAgent.cpp:439
> +   
m_client->setCacheDisabled(m_state->getBoolean(ResourceAgentState::cacheDisable
d));

Nit: I'd suggest that you put this into ::restore instead.


More information about the webkit-reviews mailing list