[webkit-reviews] review granted: [Bug 64882] Document mouseover event reporting incorrect mouse button : [Attachment 101493] report correct .which when button isn't down

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 20 13:59:13 PDT 2011


Eric Seidel <eric at webkit.org> has granted Scott Graham <scottmg at chromium.org>'s
request for review:
Bug 64882: Document mouseover event reporting incorrect mouse button
https://bugs.webkit.org/show_bug.cgi?id=64882

Attachment 101493: report correct .which when button isn't down
https://bugs.webkit.org/attachment.cgi?id=101493&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=101493&action=review


OK.  Seems fine.

> LayoutTests/fast/events/mouseover-button-expected.txt:7
> +mouseover on frame1
> +mouseover on t6 which: 0
> +mouseover on t6 which: 1
> +mouseover on t6 which: 0
> +mouseover on t6 which: 2

These woudl be better with PASS/FAIL, etc.  js-test-pre.js can help you by
giving you a shouldBe function, etc.

> LayoutTests/fast/events/mouseover-button.html:19
> +<a href="http://code.google.com/p/chromium/issues/detail?id=87473">cr
87473</a>

webkit bug?


More information about the webkit-reviews mailing list