[webkit-reviews] review granted: [Bug 64765] add new flexbox data to StyleRareNonInheritedData : [Attachment 101235] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 20 11:42:35 PDT 2011


Dave Hyatt <hyatt at apple.com> has granted Tony Chang <tony at chromium.org>'s
request for review:
Bug 64765: add new flexbox data to StyleRareNonInheritedData
https://bugs.webkit.org/show_bug.cgi?id=64765

Attachment 101235: Patch
https://bugs.webkit.org/attachment.cgi?id=101235&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=101235&action=review


r=me. One small nit.

> Source/WebCore/rendering/style/RenderStyle.h:1313
> +    static float initialFlexboxWidthPositiveFlex() { return 0.0; }
> +    static float initialFlexboxWidthNegativeFlex() { return 0.0; }
> +    static float initialFlexboxHeightPositiveFlex() { return 0.0; }
> +    static float initialFlexboxHeightNegativeFlex() { return 0.0; }

You can actually just say "0" here. You don't have to say "0.0"


More information about the webkit-reviews mailing list