[webkit-reviews] review denied: [Bug 64689] [CSSRegions]Add basic RenderRegion support : [Attachment 101321] Patch 2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 20 11:17:58 PDT 2011


Dave Hyatt <hyatt at apple.com> has denied Mihnea Ovidenie <mihnea at adobe.com>'s
request for review:
Bug 64689: [CSSRegions]Add basic RenderRegion support
https://bugs.webkit.org/show_bug.cgi?id=64689

Attachment 101321: Patch 2
https://bugs.webkit.org/attachment.cgi?id=101321&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
It's pretty hard for me to evaluate this patch without understanding a bit more
about what RenderRegion is going to be doing. At first glance it looks pretty
odd to me that RenderRegion is a replaced element. I don't quite understand
that.

I was also a bit surprised to see a RenderRegion created if regionThread is set
in the style. How does this interact with different display types? It seems
like the display type is being ignored?


More information about the webkit-reviews mailing list