[webkit-reviews] review granted: [Bug 64849] [Refactoring] Shadow inclusion cache should be managed by ShadowContentSelector : [Attachment 101432] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 20 09:23:11 PDT 2011


Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted MORITA Hajime
<morrita at google.com>'s request for review:
Bug 64849: [Refactoring] Shadow inclusion cache should be managed by
ShadowContentSelector
https://bugs.webkit.org/show_bug.cgi?id=64849

Attachment 101432: Patch
https://bugs.webkit.org/attachment.cgi?id=101432&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=101432&action=review


This is a great clean-up!

> Source/WebCore/dom/ShadowContentSelector.h:61
> +    { }

This looks a bit weird. Perhaps move definition out of decl, include at the
bottom of the header?


More information about the webkit-reviews mailing list