[webkit-reviews] review granted: [Bug 64794] MediaStream API: Merging MediaStreamContainer and MediaStreamList : [Attachment 101308] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 20 06:35:23 PDT 2011


Tony Gentilcore <tonyg at chromium.org> has granted Tommy Widenflycht
<tommyw at google.com>'s request for review:
Bug 64794: MediaStream API: Merging MediaStreamContainer and MediaStreamList
https://bugs.webkit.org/show_bug.cgi?id=64794

Attachment 101308: Patch
https://bugs.webkit.org/attachment.cgi?id=101308&action=review

------- Additional Comments from Tony Gentilcore <tonyg at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=101308&action=review


Thanks for the cleanup. Just a nit about includes to address before submission.


> Source/WebCore/dom/MediaStreamList.h:30
> +#include "MediaStream.h"

Is this really necessary here? At first glance it seems like the forward
declaration should suffice. If it is necessary, please remove the forward
declaration, otherwise please add this in the cpp.


More information about the webkit-reviews mailing list