[webkit-reviews] review granted: [Bug 62599] Errors encountered within SVG documents should be reported to the console : [Attachment 101347] 0002 - Add SVGLength::construct (rebase, add <rdar>)

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has granted Tim Horton
<timothy_horton at apple.com>'s request for review:
Bug 62599: Errors encountered within SVG documents should be reported to the
console
https://bugs.webkit.org/show_bug.cgi?id=62599

Attachment 101347: 0002 - Add SVGLength::construct (rebase, add <rdar>)
https://bugs.webkit.org/attachment.cgi?id=101347&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=101347&action=review


Looks great, r=me with one comment. Though as you can't land on your own yet,
this needs another iteration, I fear.

> Source/WebCore/svg/SVGLength.h:26
> +#include "SVGElement.h"

This include doesn't seem to be needed - can you please remove it?
Ah, I see it depends on SVGParsingError.... time to move it into a different
header?