[webkit-reviews] review granted: [Bug 59703] input type=number doesn't render correctly in rtl : [Attachment 101428] Patch

Tue Jul 19 23:53:37 PDT 2011

Ryosuke Niwa <rniwa at webkit.org> has granted Kent Tamura <tkent at chromium.org>'s
request for review:
Bug 59703: input type=number doesn't render correctly in rtl
https://bugs.webkit.org/show_bug.cgi?id=59703

Attachment 101428: Patch
https://bugs.webkit.org/attachment.cgi?id=101428&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=101428&action=review

> LayoutTests/fast/forms/input-appearance-number-rtl.html:3
> +
> +<p dir=rtl><input type=number value=1>

I'd like to see <html><body> and </p>'s since we're not really testing HTML
parser here.

> LayoutTests/fast/forms/input-appearance-number-rtl.html:14
> +document.getElementById('i5').dir = 'ltr';

Can we have another variant that sets dir to rtl?

> Source/WebCore/css/html.css:430
>  input::-webkit-textfield-decoration-container {
> -    direction: ltr;
>      display: -webkit-box;
>      -webkit-box-align: center;
>  }
>  
> +input[type="search"]::-webkit-textfield-decoration-container {
> +    direction: ltr;
> +}
> +

Does this fix input[type="speech"]?  e.g. <p dir="rtl"><input type="speech"
...>  If so, we should add a test for it.