[webkit-reviews] review denied: [Bug 64786] The value of a number input form continues to increase/decrease even if we disable the input form. : [Attachment 101426] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Kentaro Hara <haraken at google.com>'s
request for review:
Bug 64786: The value of a number input form continues to increase/decrease even
if we disable the input form.
https://bugs.webkit.org/show_bug.cgi?id=64786

Attachment 101426: Patch
https://bugs.webkit.org/attachment.cgi?id=101426&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=101426&action=review


> LayoutTests/fast/forms/spin-button-gets-disabled-or-readonly.html:60
> +	   setTimeout(function() {
> +	       shouldBeEqualToString('input.value', "1234566");
> +	       nextDelayTest();
> +	   }, 500);

We can know the first increment/decrement by 'input' event. Can we avoid
setTime() by 'input' event handler?

> Source/WebCore/html/TextFieldInputType.cpp:244
> +    if (m_innerSpinButton)
> +	  
static_cast<SpinButtonElement*>(innerSpinButtonElement())->releaseCapture();

We can avoid static_cast by changing the type of m_innerSpinButton from
RefPtr<HTMLElement> to RefPtr<SpinButtonElement>.

> Source/WebCore/html/TextFieldInputType.cpp:250
> +	  
static_cast<SpinButtonElement*>(innerSpinButtonElement())->releaseCapture();

ditto.