[webkit-reviews] review granted: [Bug 64832] fix links on the flakiness dashboard : [Attachment 101401] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 64832: fix links on the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=64832

Attachment 101401: Patch
https://bugs.webkit.org/attachment.cgi?id=101401&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=101401&action=review


> Tools/TestResultServer/static-dashboards/flakiness_dashboard.html:-1329
> -function showPopupForTest(e, test)
> -{
> -    showPopup(e, htmlForIndividulTestOnAllBuilders(test));
> -    appendExpectations();
> -}

Are you just removing dead code here?

> Tools/TestResultServer/static-dashboards/flakiness_dashboard.html:1756
> +    // FIXME: Make this DOM creation less verbose.
> +    var index = document.createElement('div');
> +    index.style.cssFloat = 'right';
> +    index.textContent = (g_currentState.updateIndex + 1) + ' of ' +
keys.length + ' tests';
> +    document.body.appendChild(index);

Maybe mention this refactoring in the ChangeLog?