[webkit-reviews] review granted: [Bug 41841] Unknown HTML elements should use the HTMLUnknownElement interface : [Attachment 101398] Fix windows and linux builds

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Tom Zakrajsek
<tomz at codeaurora.org>'s request for review:
Bug 41841: Unknown HTML elements should use the HTMLUnknownElement interface
https://bugs.webkit.org/show_bug.cgi?id=41841

Attachment 101398: Fix windows and linux builds
https://bugs.webkit.org/attachment.cgi?id=101398&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=101398&action=review


I'm not an expert on make_names, but your change looks reasonably likely to be
correct.

> LayoutTests/fast/html/script-tests/unknown-tag.js:25
> +// These tags are required by the HTML spec
> +var validTags = [
> +    "a", "abbr", "acronym", "address", "applet", "area",
> +    "article", "aside", "b", "base", "basefont", "bdo",
> +    "bgsound", "big", "blockquote", "body", "br", "button",
> +    "canvas", "caption", "center", "cite", "code", "col",
> +    "colgroup", "command", "dd", "del",
> +    "dfn", "dir", "div", "dl", "dt", "em", "embed", "fieldset",
> +    "figcaption", "figure", "font", "footer", "form", "frame",
> +    "frameset", "h1", "h2", "h3", "h4", "h5", "h6", "head",
> +    "header", "hgroup", "hr", "html", "i", "iframe", "image",
> +    "img", "input", "ins", "isindex", "kbd", "keygen", "label",
> +    "layer", "legend", "li", "link", "listing", "map", "mark",
> +    "marquee", "menu", "meta", "nav", "nobr",
> +    "noembed", "noframes", "nolayer", "noscript", "object",
> +    "ol", "optgroup", "option", "output", "p", "param",
> +    "plaintext", "pre", "q", "rp", "rt", "ruby",
> +    "s", "samp", "script", "section", "select", "small",
> +    "span", "strike", "strong", "style", "sub",
> +    "sup", "table", "tbody", "td", "textarea",
> +    "tfoot", "th", "thead", "title", "tr", "tt", "u",
> +    "ul", "var", "wbr", "xmp"
> +];

This seems like a pain to maintain this list.

> Source/WebCore/ChangeLog:36
> -	   
> +
>	   It was possible to recurse via
updateGeometry/swapFromOrToTiledLayer/
>	   updateContentsScale because updateGeometry() and
updateContentsScale()
>	   used different sizes; updateGeometry() used the scaled size, while
>	   updateContentsScale() used the unscaled size.
> -	   
> +

These diffs shouldn't be here.