[webkit-reviews] review granted: [Bug 64800] Store line number on TestExpectationLine. : [Attachment 101325] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 19 15:19:07 PDT 2011


Adam Barth <abarth at webkit.org> has granted Dimitri Glazkov (Google)
<dglazkov at chromium.org>'s request for review:
Bug 64800: Store line number on TestExpectationLine.
https://bugs.webkit.org/show_bug.cgi?id=64800

Attachment 101325: Patch
https://bugs.webkit.org/attachment.cgi?id=101325&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=101325&action=review


> Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:316
> +	   line_number = 0
>	   for line in expectations_string.split("\n"):
> -	       expectation_lines.append(cls.tokenize(line))
> +	       line_number += 1

No enumerate?


More information about the webkit-reviews mailing list