[webkit-reviews] review denied: [Bug 64824] [Mac] Need to make sure autocorrection panel is dismissed in Document::setFocusNode(). : [Attachment 101386] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 19 14:27:04 PDT 2011


Darin Adler <darin at apple.com> has denied Jia Pu <jpu at apple.com>'s request for
review:
Bug 64824: [Mac] Need to make sure autocorrection panel is dismissed in
Document::setFocusNode().
https://bugs.webkit.org/show_bug.cgi?id=64824

Attachment 101386: Patch v1
https://bugs.webkit.org/attachment.cgi?id=101386&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=101386&action=review


> Source/WebCore/dom/Document.cpp:3098
> +	   frame()->editor()->dismissCorrectionPanelAsIgnored();

It seems strange and wrong to put this inside the check for
oldFocusedNode->inDetach.

It’s irritating that we have to actually utter the words “correction panel”
here, but I can’t see a better way to structure this.


More information about the webkit-reviews mailing list