[webkit-reviews] review denied: [Bug 64732] Refactor automatically generated JS DOM bindings to replace operator new with static create methods : [Attachment 101375] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jul 19 13:48:36 PDT 2011
Darin Adler <darin at apple.com> has denied Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 64732: Refactor automatically generated JS DOM bindings to replace operator
new with static create methods
https://bugs.webkit.org/show_bug.cgi?id=64732
Attachment 101375: Patch
https://bugs.webkit.org/attachment.cgi?id=101375&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
When changing bindings, you should run the command line tool named
run-bindings-tests. It will show you the generated code so you can proofread
it. Then you should use run-bindings-tests --reset-results to overwrite the
results and include the changes to expected results in your patch.
Otherwise, looks great.
More information about the webkit-reviews
mailing list