[webkit-reviews] review granted: [Bug 63381] [GTK] [WK2] Implement missing initializeLogChannel function. : [Attachment 100864] WebKit2 Logging for GTK port implementation

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 19 11:55:44 PDT 2011


Martin Robinson <mrobinson at webkit.org> has granted Lukasz Slachciak
<l.slachciak at samsung.com>'s request for review:
Bug 63381: [GTK] [WK2] Implement missing initializeLogChannel function.
https://bugs.webkit.org/show_bug.cgi?id=63381

Attachment 100864: WebKit2 Logging for GTK port implementation
https://bugs.webkit.org/attachment.cgi?id=100864&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=100864&action=review


> Source/WebKit2/Platform/gtk/LoggingGtk.cpp:43
> +    // fulfill activatedChannels vector only once basing on names set in
logEnv

This comment should probably read:

Fill activatedChannels vector only once based on names set in logEnv.

According to WebKit style guidelines, comments need to be a full sentence with
a capital and period.


More information about the webkit-reviews mailing list